ext: Use new C API for unique references #278
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngoldbaum
force-pushed
the
fix-refcnt
branch
from
08733dd to
48fb689
Compare
|
Test failure looks unrelated? Ping @indygreg could you point a way forward here? |
clin1234
reviewed
Sep 12, 2025
| PyObject *tmp; | ||
|
|
||
| if (Py_REFCNT(*obj) == 1) { | ||
| if (PyUnstable_Object_IsUniquelyReferenced(*obj)) { |
There was a problem hiding this comment.
Perhaps add a note that using the Unstable API may require reinspecting this every time a new minor Python is bumped?
Other than this, LGTM
indygreg
approved these changes
Sep 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python 3.14 C API added
PyUnstable_Object_IsUniquelyReferenced, which enabled checks like this to be thread-safe on the free-threaded build.I had to update the pythoncapi-compat header to get a copy of the shim I added in python/pythoncapi-compat#149.